Emmanuele Bassi [Sat, 16 Nov 2019 18:19:26 +0000 (18:19 +0000)]
Merge branch 'gdkx-import-doc' into 'master'
Correct GdkX11 import path in docs and include guards
Closes #2254
See merge request GNOME/gtk!1188
Andy Holmes [Fri, 15 Nov 2019 21:13:26 +0000 (13:13 -0800)]
Correct GdkX11 import path in docs and include guards
Update the include directives in the documentation, as well as the
include guards in headers, to point to gdk/x11/gdkx.h.
closes #2254
Emmanuele Bassi [Fri, 15 Nov 2019 23:26:17 +0000 (23:26 +0000)]
Merge branch 'fix-menu-check-radio-styling-gtk4' into 'master'
Adwaita: Fix check/radio styling in menu (GTK4)
See merge request GNOME/gtk!1187
Emmanuele Bassi [Fri, 15 Nov 2019 23:24:42 +0000 (23:24 +0000)]
Merge branch 'dont-hardcode-shared-library' into 'master'
build: Don't hardcode shared_library() in meson
See merge request GNOME/gtk!1172
Niklas Hambüchen [Mon, 11 Nov 2019 19:11:16 +0000 (20:11 +0100)]
Try building static libs on CI
nana-4 [Fri, 15 Nov 2019 16:08:44 +0000 (01:08 +0900)]
Adwaita: Fix check/radio styling in menu
The new check/radio style increased their specificity, but it was not
synchronized in the menu styling.
This commit increases the specificity to match the updated check/radio
styling.
https://gitlab.gnome.org/GNOME/gtk/issues/2096
Emmanuele Bassi [Fri, 15 Nov 2019 13:05:39 +0000 (13:05 +0000)]
Merge branch 'building-docs' into 'master'
Document the use of build types when configuing GTK
See merge request GNOME/gtk!1113
Emmanuele Bassi [Fri, 15 Nov 2019 12:36:12 +0000 (12:36 +0000)]
Merge branch 'Master_checkradio_refresh' into 'master'
Refresh check/radio styling, ported from gtk3
See merge request GNOME/gtk!1175
frederik.feichtmeier [Fri, 15 Nov 2019 12:16:07 +0000 (13:16 +0100)]
Refresh check/radio styling, ported from gtk3
Emmanuele Bassi [Thu, 14 Nov 2019 16:30:49 +0000 (16:30 +0000)]
Merge branch 'fix-emoji-picker-styling' into 'master'
Adwaita: Fix emoji picker styling (GTK4)
See merge request GNOME/gtk!1181
nana-4 [Thu, 14 Nov 2019 15:04:18 +0000 (00:04 +0900)]
Adwaita: Fix emoji picker styling
- Adjust the emoji picker appearance to be the same as gtk3's.
- Fix button.emoji-section margins in RTL.
- Prevent the .emoji hover effect from being applied to the entire
nested popover.
Kjell Ahlstedt [Wed, 13 Nov 2019 14:20:34 +0000 (15:20 +0100)]
headerbar: Disconnect signal handlers when children are removed
The signal handler that calls notify_child_cb() is disconnected
from a child widget before the child is removed from the header bar.
gtk_header_bar_dispose() chains up before destroying the start and end
boxes, thus avoiding calls to notify_child_cb() after start_box and
end_box have been cleared.
Fixes #2246
Timm Bäder [Sat, 26 Oct 2019 16:22:27 +0000 (18:22 +0200)]
inspector: Select an object when activating it
Timm Bäder [Thu, 7 Nov 2019 06:32:03 +0000 (07:32 +0100)]
css: short-circuit gtk_css_dimension_value_try_add
No need to allocate a new css value for something that we already have,
because one of the two values is 0
Timm Bäder [Thu, 7 Nov 2019 06:31:04 +0000 (07:31 +0100)]
cssdimenstionvalue: Add common degree value singletons
Timm Bäder [Thu, 7 Nov 2019 06:30:42 +0000 (07:30 +0100)]
cssdimensionvalue: Add 50% singleton
Also pretty common
Timm Bäder [Thu, 7 Nov 2019 06:29:45 +0000 (07:29 +0100)]
cssdimensionvalue: Add more common pixel values
These are used for icon sizes, etc.
Timm Bäder [Thu, 7 Nov 2019 05:49:43 +0000 (06:49 +0100)]
cssimagerecolor: Avoid copying colors
Timm Bäder [Fri, 25 Oct 2019 08:36:29 +0000 (10:36 +0200)]
popover: Use a bin layout for the contents gizmo
Timm Bäder [Fri, 25 Oct 2019 08:35:53 +0000 (10:35 +0200)]
testpopover: Plug two GtkBuilder leaks
Timm Bäder [Wed, 13 Nov 2019 14:29:01 +0000 (14:29 +0000)]
Merge branch 'wip/christopherdavis/issue-2233' into 'master'
Adwaita: remove unwanted spacing for boxes as titlebars
Closes #2233
See merge request GNOME/gtk!1177
Christopher Davis [Wed, 13 Nov 2019 00:09:10 +0000 (16:09 -0800)]
Adwaita: remove unwanted spacing for boxes as titlebars
A GtkBox in a titlebar could have unwanted spacing.
This caused a glitch in split-header applications where
parts of the titlebar would be transparent or black.
This commit tweaks Adwaita to make sure no spacing is added for boxes when used as titlebars.
Fixes #2233
Timm Bäder [Wed, 13 Nov 2019 10:40:02 +0000 (10:40 +0000)]
Merge branch 'master.msvc.fix' into 'master'
gtk/gtkcssrgbavalue.c: Fix build on Visual Studio
See merge request GNOME/gtk!1178
Chun-wei Fan [Wed, 13 Nov 2019 09:14:31 +0000 (17:14 +0800)]
gtk/gtkcssrgbavalue.c: Fix build on Visual Studio
Visual Studio does not allow static or global structures to use
static storage duration by compound literals, which is actually a
GCCism[1].
[1]: See https://gcc.gnu.org/onlinedocs/gcc/Compound-Literals.html
Emmanuele Bassi [Mon, 11 Nov 2019 16:11:06 +0000 (16:11 +0000)]
Merge branch 'issue-2230' into 'master'
Add GtkCss API to the introspection data
Closes #2230
See merge request GNOME/gtk!1173
Emmanuele Bassi [Mon, 11 Nov 2019 15:53:09 +0000 (15:53 +0000)]
Add GtkCss API to the introspection data
Some of the CSS API has been moved to a public namespace, so we need to
include it into the introspection data we build in order for people to
use it.
Fixes: #2230
Niklas Hambüchen [Mon, 11 Nov 2019 15:37:46 +0000 (16:37 +0100)]
build: Don't hardcode shared_library() in meson.
Instead, use the standard library().
This is a meson best practice.
Fixes -Ddefault_library=static not having any effect.
Emmanuele Bassi [Tue, 1 Oct 2019 15:27:23 +0000 (16:27 +0100)]
docs: Rename SGML files
We've been using XML for ages.
Emmanuele Bassi [Tue, 1 Oct 2019 15:21:40 +0000 (16:21 +0100)]
docs: Fix the XML indentation
Emmanuele Bassi [Tue, 1 Oct 2019 15:20:37 +0000 (16:20 +0100)]
docs: We run meson, not configure
Emmanuele Bassi [Tue, 1 Oct 2019 15:19:12 +0000 (16:19 +0100)]
docs: Add a section on supported build types
GTK uses the Meson `buildtype` option to determine whether to enable or
disable debugging code and safeties. We should document our behaviour
and expectations.
Piotr Drąg [Sun, 10 Nov 2019 11:45:22 +0000 (12:45 +0100)]
Update Polish translation
Daniel Mustieles [Fri, 8 Nov 2019 11:44:39 +0000 (12:44 +0100)]
Updated Spanish translation
Timm Bäder [Thu, 7 Nov 2019 11:56:17 +0000 (11:56 +0000)]
Merge branch 'adwaita-emoji-picker-adjustments-gtk4' into 'master'
Adwaita: Emoji picker adjustments
See merge request GNOME/gtk!1160
Alex Monday [Sun, 3 Nov 2019 08:38:11 +0000 (08:38 +0000)]
Adwaita: Emoji picker adjustments
- Add margins for search entry;
- Increase side margins for emoji-section buttons box;
- Apply border-radius on hovered emoji;
- Adjust indication of hovered emoji-section button.
Benjamin Otte [Tue, 5 Nov 2019 19:08:22 +0000 (19:08 +0000)]
Merge branch 'kill-entry-buffer-demo' into 'master'
gtk-demo: Drop the entry buffer demo
See merge request GNOME/gtk!1166
Benjamin Otte [Tue, 5 Nov 2019 00:10:22 +0000 (01:10 +0100)]
scrolledwindow: Use dispose(), not destroy()
Benjamin Otte [Tue, 5 Nov 2019 18:52:25 +0000 (18:52 +0000)]
Merge branch 'wip/chergert/textundo' into 'master'
Add undo/redo support for GtkTextView, GtkText, and GtkEntry
See merge request GNOME/gtk!1158
Matthias Clasen [Tue, 5 Nov 2019 18:44:49 +0000 (18:44 +0000)]
gtk-demo: Drop the entry buffer demo
We all agree that entry buffers are not something
we should promote in demos.
Christian Hergert [Mon, 4 Nov 2019 22:14:42 +0000 (14:14 -0800)]
migration: add GtkEntryBuffer::deleted-text to migration guide
Christian Hergert [Fri, 1 Nov 2019 18:30:33 +0000 (11:30 -0700)]
gtk-demo: set irreversable actions for textview demos
Christian Hergert [Fri, 1 Nov 2019 18:20:22 +0000 (11:20 -0700)]
gtk-demo: add a demo for TextView undo/redo
Christian Hergert [Fri, 1 Nov 2019 18:20:02 +0000 (11:20 -0700)]
gtk-demo: add an undo demo for GtkEntry
Christian Hergert [Fri, 1 Nov 2019 18:18:21 +0000 (11:18 -0700)]
gtk-demo: wrap text operations in irreversible actions
This ensures that the actions to set the text for the demo tabs cannot
be undone. This matches the previous behavior for GtkTextBuffer.
Christian Hergert [Fri, 1 Nov 2019 18:13:30 +0000 (11:13 -0700)]
text: add undo support to GtkText
This adds support using the GtkTextHistory helper for undo/redo to the
GtkText widget. It is similar in use to GtkTextView, but with a simplified
interface.
You can disable undo support using the GtkText:enable-undo property. By
default, it is enabled.
Christian Hergert [Fri, 1 Nov 2019 18:15:35 +0000 (11:15 -0700)]
entrybuffer: remove text in ::deleted-text default handler
This changes the semantics of ::deleted-text to perform the removal of
text in the default handler. This means, that if you want the old behavior
where your signal handler is called after the text has been deleted, you
should connect with G_CONNECT_AFTER in your signal handler (or use
g_signal_connect_after).
Without this change, there was never a way to get the deleted-text before
the operation had completed and this is necessary to provide undo support
to the text widgets.
Christian Hergert [Tue, 5 Nov 2019 00:40:02 +0000 (16:40 -0800)]
editable: add enable-undo property
This property is intended to be mapped to a GtkText so that undo/redo
support can be used from a number of editable widgets.
Christian Hergert [Fri, 1 Nov 2019 18:12:21 +0000 (11:12 -0700)]
textview: add undo/redo support to GtkTextView
This builds upon the GtkTextHistory helper to provide undo and redo support
for the GtkTextView widget and GtkTextBuffer object.
You can undo/redo using familiar shortcuts such as Primary+Z,
Primary+Shift+Z, ad Primary+Y.
Developers that wish to disable undo, should set the
GtkTextBuffer:enable-undo property to FALSE.
You can wrap irreversible actions
gtk_text_buffer_begin_irreversible_action() and
gtk_text_buffer_end_irreversible_action(). This will cause the undo stack
to drop all undo/redo actions and the changes made between them will be
the "initial state" of the buffer.
Calling gtk_text_buffer_set_text() will do this automatically for you.
Christian Hergert [Thu, 24 Oct 2019 02:13:11 +0000 (19:13 -0700)]
texthistory: add GtkTextHistory helper
The GtkTextHistory helper provides the fundamental undo/redo stack that
can be integrated with other text widgets. It allows coalescing related
actions to reduce both the number of undo actions to the user as well as
the memory overhead.
A new istring helper is used by GtkTextHistory to allow for "inline
strings" that gracefully grow to using allocations with g_realloc(). This
ensure that most undo operations require no additional allocations other
than the struct for the action itself.
A queue of undoable and redoable actions are maintained and the link for
the queue is embedded in the undo action union. This allows again, for
reducing the number of allocations involved for undo operations.
Daniel Mustieles [Tue, 5 Nov 2019 14:44:34 +0000 (15:44 +0100)]
Updated Spanish translation
Emmanuele Bassi [Tue, 5 Nov 2019 10:44:05 +0000 (10:44 +0000)]
ci: Allow msys2 jobs to fail
The msys2 runner has started failing for internal reasons:
- gtk-3-24 times out
- master fails with a ld.exe assertion:
BFD (GNU Binutils) 2.33.1 assertion fail
../../binutils-2.33.1/bfd/cofflink.c:2348
Both seem related to some MSYS2 issue. Until the runner is updated, we
should not block on it.
Emmanuele Bassi [Mon, 4 Nov 2019 23:46:22 +0000 (23:46 +0000)]
tests: Add label-sizing.ui to the XFAIL list
Changes in Pango may make this test fail.
Emmanuele Bassi [Mon, 4 Nov 2019 23:35:49 +0000 (23:35 +0000)]
Revert "Adwaita: radios & checkboxes styling updates"
This reverts commit
427b5d187c8ca5f099b5d4f84664ccc6a560a919.
The commit breaks Adwaita:
Theme parsing error: gtk-contained.css:1191:28-44: No property named "-gtk-icon-effect"
Matthias Clasen [Mon, 4 Nov 2019 23:24:49 +0000 (23:24 +0000)]
Move the ifdef to the right spot
Matthias Clasen [Mon, 4 Nov 2019 23:14:44 +0000 (23:14 +0000)]
cell text: Handle new pango enum values
The PangoUnderline enum grew some new values.
Jakub Steiner [Mon, 4 Nov 2019 18:41:58 +0000 (19:41 +0100)]
Adwaita: radios & checkboxes styling updates
- port from gtk3
Benjamin Otte [Mon, 4 Nov 2019 17:46:28 +0000 (17:46 +0000)]
Merge branch 'wip/sadiq/fix-leak' into 'master'
selection-output-stream-x11: Fix a memory leak
See merge request GNOME/gtk!1149
Benjamin Otte [Mon, 4 Nov 2019 02:35:22 +0000 (02:35 +0000)]
Merge branch 'gtkstack-addnamed-return' into 'master'
stack: return the stack page when adding a child, to ease setting props
See merge request GNOME/gtk!1161
Andy Holmes [Mon, 4 Nov 2019 02:05:03 +0000 (18:05 -0800)]
stack: return the stack page when adding a child, to ease setting props
Christian Hergert [Fri, 1 Nov 2019 18:32:31 +0000 (11:32 -0700)]
textview: use g_slice_new0 for proper initial state
This fixes the missuse of the GList embedded node for prev/next.
Matthias Clasen [Fri, 1 Nov 2019 17:45:38 +0000 (17:45 +0000)]
Merge branch 'reftest-fixes' into 'master'
Reftest fixes
See merge request GNOME/gtk!1157
Matthias Clasen [Fri, 1 Nov 2019 17:33:15 +0000 (13:33 -0400)]
reftests: Print out a helpful error
When module loading fails, print out the error.
Matthias Clasen [Fri, 1 Nov 2019 17:32:56 +0000 (13:32 -0400)]
reftests: Drop libtool hack
We are not using libtool anymore.
Matthias Clasen [Fri, 1 Nov 2019 17:26:33 +0000 (17:26 +0000)]
Merge branch 'bump-pango' into 'master'
Bump pango
See merge request GNOME/gtk!1154
Matthias Clasen [Fri, 1 Nov 2019 13:15:24 +0000 (09:15 -0400)]
label: Handle new pango attributes
overline and overline-color were introduced in Pango 1.45.
Matthias Clasen [Tue, 13 Aug 2019 21:33:33 +0000 (17:33 -0400)]
label: Handle insert_hyphens pango attribute
This was introduced in Pango 1.44.4.
Matthias Clasen [Fri, 2 Aug 2019 03:42:21 +0000 (23:42 -0400)]
gsk: Stop using deprecated pango api
Shape engines are not used anymore.
Matthias Clasen [Tue, 30 Jul 2019 20:34:23 +0000 (16:34 -0400)]
build: We no longer need freetype
Matthias Clasen [Tue, 30 Jul 2019 20:32:34 +0000 (16:32 -0400)]
gtk-demo: Use harfbuzz for font features
We don't need freetype anymore here; harfbuzz
has what we need.
Matthias Clasen [Wed, 24 Jul 2019 12:02:07 +0000 (08:02 -0400)]
Port the font chooser to just use harfbuzz
Matthias Clasen [Fri, 1 Nov 2019 13:09:28 +0000 (09:09 -0400)]
Bump the pango dependency
This lets us avoid freetype uses, and simplifies
some other things as well.
Matthias Clasen [Fri, 1 Nov 2019 17:00:34 +0000 (17:00 +0000)]
Merge branch 'fix-print-dialog' into 'master'
Update the print dialog for headerbar changes
See merge request GNOME/gtk!1156
Matthias Clasen [Fri, 1 Nov 2019 16:51:42 +0000 (12:51 -0400)]
Update the print dialog for headerbar changes
This was breaking the templates test.
Matthias Clasen [Fri, 1 Nov 2019 16:30:17 +0000 (16:30 +0000)]
Merge branch 'ci-update' into 'master'
Update the CI image
See merge request GNOME/gtk!1155
Emmanuele Bassi [Fri, 1 Nov 2019 15:44:12 +0000 (15:44 +0000)]
ci: Add internal links to the HTML report
Makes it easier to link to various sections, and to specific failures.
Emmanuele Bassi [Fri, 1 Nov 2019 15:22:02 +0000 (15:22 +0000)]
ci: Add diffutils to the CI image
Some transitive dependency got dropped, and we lost diff.
Emmanuele Bassi [Fri, 1 Nov 2019 15:20:47 +0000 (15:20 +0000)]
Check for diff's availability
The tests suite calls `diff` in various places, which means we need to
check if it's installed.
Benjamin Otte [Fri, 1 Nov 2019 14:13:28 +0000 (14:13 +0000)]
Merge branch 'otte/for-master' into 'master'
Otte/for master
See merge request GNOME/gtk!1153
Benjamin Otte [Fri, 1 Nov 2019 13:49:41 +0000 (14:49 +0100)]
vulkan: Add missing enum value
Also update comment to point to new header after Vulkan reorganized
their repositories.
Emmanuele Bassi [Fri, 1 Nov 2019 12:52:19 +0000 (12:52 +0000)]
ci: Update the image to Fedora 31
Fedora 31 ships with a newer version of Pango.
Matthias Clasen [Thu, 31 Oct 2019 02:55:34 +0000 (02:55 +0000)]
Merge branch 'fallback-rendering' into 'master'
Fallback rendering
See merge request GNOME/gtk!1152
Matthias Clasen [Thu, 31 Oct 2019 02:31:27 +0000 (22:31 -0400)]
inspector: Add a switch for fallback rendering
Matthias Clasen [Thu, 31 Oct 2019 02:30:34 +0000 (22:30 -0400)]
gl: Use the fallback debug flag
This debug flag was unused; use it to enable
fallback highlighting at runtime.
Matthias Clasen [Thu, 31 Oct 2019 02:31:06 +0000 (22:31 -0400)]
inspector: Remove fallback from logs
There are no logs that this debug flag produces.
Matthias Clasen [Wed, 30 Oct 2019 02:39:49 +0000 (02:39 +0000)]
Merge branch 'wl-key-repeat' into 'master'
wayland: Rely on server key repeat info
See merge request GNOME/gtk!1150
Matthias Clasen [Wed, 30 Oct 2019 02:20:57 +0000 (22:20 -0400)]
wayland: Drop the keyboard settings object
It is no longer used.
Matthias Clasen [Wed, 30 Oct 2019 01:55:13 +0000 (21:55 -0400)]
wayland: Rely on server key repeat info
Using gsettings for this information does not work
in sandboxed scenarios, where settings are per-app.
Since the Wayland protocol provides this information
nowadays, just drop the old code for reading
the gsettings.
Benjamin Otte [Mon, 21 Oct 2019 02:57:03 +0000 (04:57 +0200)]
builder: Allow parsing G_TYPE_BYTES from strings
Just create a bytes containing the literal string.
Benjamin Otte [Sat, 26 Oct 2019 05:00:24 +0000 (07:00 +0200)]
togglebutton: Don't emit clicked during set_active()
set_active() is meant to set the state of the property, which happens
during setup.
The clicked signal is emitting events from user actions.
It is impossible to use Togglebuttons for MVC applications as long as it
does that.
Benjamin Otte [Mon, 28 Oct 2019 19:00:21 +0000 (20:00 +0100)]
messagedialog: Remove useless GTK_TYPE_BUILDABLE interface
It was just chaining up.
Mohammed Sadiq [Sun, 27 Oct 2019 08:16:37 +0000 (13:46 +0530)]
gdkselectionoutputstream-x11: Fix a memory leak
Matthias Clasen [Wed, 23 Oct 2019 01:20:36 +0000 (21:20 -0400)]
gtk-demo: Add a scrolling image demo
This tests big textures.
Matthias Clasen [Tue, 22 Oct 2019 23:52:14 +0000 (19:52 -0400)]
window: Unrealize renderer before children
Unrealize the GSK renderer before destroying children.
This makes the renderer drop any texture caches that
it might have, so that we don't needlessly download
them when releasing the widget-side holder objects.
As a fortunate side effect, this fixes crashes on
exit with GtkGLArea-containing windows under Wayland.
Matthias Clasen [Tue, 22 Oct 2019 13:23:06 +0000 (13:23 +0000)]
Merge branch 'readonly-all-the-things' into 'master'
Readonly all the things
See merge request GNOME/gtk!1145
Matthias Clasen [Tue, 22 Oct 2019 06:39:56 +0000 (02:39 -0400)]
Revert "gl: Speed up icon cache lookups"
This reverts commit
dd5ee87b5b65fff51e671ed092e18a524de78379.
Matthias Clasen [Tue, 22 Oct 2019 06:28:33 +0000 (02:28 -0400)]
gl: Avoid pointless iteration
Matthias Clasen [Tue, 22 Oct 2019 06:27:28 +0000 (02:27 -0400)]
gl: Add some comments
Matthias Clasen [Tue, 22 Oct 2019 05:34:56 +0000 (01:34 -0400)]
Revert "Cache glyph textures in render nodes"
This reverts commit
c5af4638434e39a0c224afb62252caed233c2acb.
Timm Bäder [Sun, 20 Oct 2019 14:34:24 +0000 (16:34 +0200)]
inspector: Fix expander arrow node names
They vanished after the GtkExpander node rename
Timm Bäder [Sun, 20 Oct 2019 11:03:52 +0000 (13:03 +0200)]
filechooserwidget: Remove unused function parameter